RFR(S): 8168341: Gtests on JSon produce an enormous amount of hardly understandable output to stdout

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Wed Nov 30 20:12:19 UTC 2016


Vladimir,

Thank you!

Regards, Kirill

On 29.11.2016 20:19, Vladimir Kozlov wrote:
> +1
>
> On 11/29/16 4:02 AM, Igor Ignatyev wrote:
>> Kirill,
>>
>> still looks good to me
>>
>> Thanks,
>> — Igor
>>> On Nov 29, 2016, at 2:58 PM, Kirill Zhaldybin
>>> <kirill.zhaldybin at oracle.com> wrote:
>>>
>>> Dear all,
>>>
>>> I found (unfortunately a bit late) that stringStream requires
>>> ResourceMark.
>>>
>>> Here are a new WebRev:
>>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8168341/webrev.01/
>>> The only differences are added resource mark, #include
>>> "memory/resourceArea.hpp" and fixed indents.
>>>
>>> Could you please let me know your opinion?
>>>
>>> Thank you.
>>>
>>> Regards, Kirill
>>>
>>> On 25.11.2016 21:12, Kirill Zhaldybin wrote:
>>>> Dear all,
>>>>
>>>> Could you please review this fix for 8168341?
>>>>
>>>> I redirected output to stringStream instead of tty and appended it
>>>> to an
>>>> assert message in case of failure.
>>>>
>>>> WebRev:
>>>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8168341/webrev.00/
>>>> CR: https://bugs.openjdk.java.net/browse/JDK-8168341
>>>>
>>>> Thank you.
>>>>
>>>> Regards, Kirill
>>>
>>



More information about the hotspot-compiler-dev mailing list