RFR 8166929: [JVMCI] Expose decompile counts in MDO

[Christian Thalinger]

> On Oct 2, 2016, at 8:23 PM, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:
> 
>> 
>> Unrelated question:
>>          String nl = String.format("%n");
>>          String nlIndent = String.format("%n%38s", "");
>> +        sb.append("Raw method data for ");
>> +        sb.append(method.format("%H.%n(%p)"));
>> +        sb.append(":");
>> +        sb.append(nl);
>> +        sb.append(String.format("nof_decompiles(%d) nof_overflow_recompiles(%d) nof_overflow_traps(%d)%n",
>> +                        getDecompileCount(), getOverflowRecompileCount(), getOverflowTrapCount()));
>> Is pre-formatting nl really a win?  If yes, why are we not doing the same trick on the last line?
> 
> String.format and StringBuilder don’t really play very well together.  I moved some code which was using plus and added some which was using format and the result isn’t very pretty.  I can change the 4 appends into  format if you like.

No, it’s fine; was just a question.  The change is good to go.

> 
> tom
> 
>> 
>>> 
>>> tom
>>> 
>>>> 
>>>>> 
>>>>> tom
>>>>> 
>>>>>> 
>>>>>> Thanks
>>>>>> 
>>>>>> On Thursday, September 29, 2016, Tom Rodriguez <tom.rodriguez at oracle.com <mailto:tom.rodriguez at oracle.com>> wrote:
>>>>>> http://cr.openjdk.java.net/~never/8166929/webrev <http://cr.openjdk.java.net/~never/8166929/webrev>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8166929 <https://bugs.openjdk.java.net/browse/JDK-8166929>
>>>>>> 
>>>>>> This is a minor API addition to expose some of the top-level MDO decompile and recompile counts.  It’s necessary to detect recompilation pathologies.  Tested by printing MDOs from JVMCI.  I also fixed a few problems I discovered with the formatting of the MDO printed form.
>>>>>> 
>>>>>> tom
>>>>>> 
>>>>>> 
>>>>>> -- 
>>>>>> Sent from my phone
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20161003/8cc0a76e/attachment.html>