RFR (M): 8164546: Convert DirectivesParser_test to GTest

Nils Eliasson nils.eliasson at oracle.com
Mon Oct 10 08:21:37 UTC 2016


Hi Pavel,

Looks good, thanks for fixing!

The credit belongs to Andreas Eriksson who also wrote the parser.

Best regards,
Nils Eliasson

On 2016-10-06 19:38, Pavel Punegov wrote:
> Hi,
>
> please review this change that rewrites a native test to Gtest framework.
> The fix removes test methods from the DirectiveParser and makes test 
> cases use DirectiveParser::parse_string method instead.
> The original test was written by Nils Eliasson.
>
> webrev: http://cr.openjdk.java.net/~ppunegov/8164546/webrev.02/ 
> <http://cr.openjdk.java.net/%7Eppunegov/8164546/webrev.02/>
> bug: https://bugs.openjdk.java.net/browse/JDK-8164546
>
> — Thanks,
> Pavel Punegov
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20161010/188c60dd/attachment.html>


More information about the hotspot-compiler-dev mailing list