RFR: 8167180: [JVMCI] Exported elements referring to inaccessible types in jdk.vm.ci

[Alan Bateman]

On 10/10/2016 21:18, Doug Simon wrote:

> Please review this change which JVMCI API changes to address lint warnings introduced by https://bugs.openjdk.java.net/browse/JDK-8153362.
>
> JVMCI currently exports a few service types that are in exported packages so that a ServiceLoader can load them. The problem is that some of these service types reference other JVMCI types that are not in exported packages as reported by the new lint check. To address this mixing of exported and non-exported types, this webrev introduces a new (meta) service, jdk.vm.ci.services.JVMCIAccess, that is now used to get providers for all other services:
>
> jdk.vm.ci.runtime.JVMCICompilerFactory
> jdk.vm.ci.hotspot.HotSpotVMEventListener
>
> All uses of JVMCIAccess are subject to SecurityManager checks.
>
> https://bugs.openjdk.java.net/browse/JDK-8167180
> http://cr.openjdk.java.net/~dnsimon/8167180/
>
I skimmed over the webrev. My only real comment is on JVMCIAccess where 
there may be alternative names that work better (it feels more like a 
JVMTIServicesFactory or JVMTIProviderFactory). The class description 
probably needs a bit of wordsmithing too, esp. "Service for the runtime 
...".

-Alan