RFR: 8168567 - Fix for 81666972 (not 8160376) breaks aarch64 build

White, Derek Derek.White at cavium.com
Mon Oct 24 17:31:53 UTC 2016


Thanks Andrew. 

In the past I've had to create the changeset after the reviewer's comments have been resolved. I'll post something in a minute...

 - Derek

-----Original Message-----
From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Andrew Haley
Sent: Monday, October 24, 2016 1:26 PM
To: hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR: 8168567 - Fix for 81666972 (not 8160376) breaks aarch64 build

On 24/10/16 18:18, White, Derek wrote:
> Please review simple fix to repair aarch64 build.
> 
> 
> BUG: JDK-8168567 (https://bugs.openjdk.java.net/browse/JDK-8168567)
> 
> Webrev: http://cr.openjdk.java.net/~drwhite/8168567/webrev.01
> 
> 
> Built on aarch64, smoketested.

OK, thanks.

It can't be committed as it is, because the changeset is not correct.
The trick is to commit the patch to your local Mercurial repo before running webrev.

Here's an example of a good one:

http://cr.openjdk.java.net/~aph/8079459/jdk.changeset

Andrew.


More information about the hotspot-compiler-dev mailing list