RFR: 8168567 - Fix for 81666972 (not 8160376) breaks aarch64 build

[White, Derek]

Hi Ningsheng,

Thanks for catching that. 

I messed up, but the commit message title is correct. That *is* the title for bug ID JDK-8168567, but there's an error in the title of the bug :-)

Andrew, do you want me to fix both before checking in the fix?

 - Derek

-----Original Message-----
From: Ningsheng Jian [mailto:ningsheng.jian at linaro.org] 
Sent: Monday, October 24, 2016 9:55 PM
To: White, Derek <Derek.White at cavium.com>
Cc: Andrew Haley <aph at redhat.com>; hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR: 8168567 - Fix for 81666972 (not 8160376) breaks aarch64 build

Hi Derek,

Thanks a lot for helping that!

There is a typo in the commit message title. It should be 8166972 instead of 81666972.

Thanks,
Ningsheng

On 25 October 2016 at 01:40, White, Derek <Derek.White at cavium.com> wrote:
> Hi Andrew,
>
> Update is at http://cr.openjdk.java.net/~drwhite/8168567/webrev.02/
>
> Please let me know if there's an issue with this.
>
>  - Derek
>
> -----Original Message-----
> From: hotspot-compiler-dev 
> [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of 
> White, Derek
> Sent: Monday, October 24, 2016 1:32 PM
> To: Andrew Haley <aph at redhat.com>; 
> hotspot-compiler-dev at openjdk.java.net
> Subject: RE: RFR: 8168567 - Fix for 81666972 (not 8160376) breaks 
> aarch64 build
>
> Thanks Andrew.
>
> In the past I've had to create the changeset after the reviewer's comments have been resolved. I'll post something in a minute...
>
>  - Derek
>
> -----Original Message-----
> From: hotspot-compiler-dev 
> [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of 
> Andrew Haley
> Sent: Monday, October 24, 2016 1:26 PM
> To: hotspot-compiler-dev at openjdk.java.net
> Subject: Re: RFR: 8168567 - Fix for 81666972 (not 8160376) breaks 
> aarch64 build
>
> On 24/10/16 18:18, White, Derek wrote:
>> Please review simple fix to repair aarch64 build.
>>
>>
>> BUG: JDK-8168567 (https://bugs.openjdk.java.net/browse/JDK-8168567)
>>
>> Webrev: http://cr.openjdk.java.net/~drwhite/8168567/webrev.01
>>
>>
>> Built on aarch64, smoketested.
>
> OK, thanks.
>
> It can't be committed as it is, because the changeset is not correct.
> The trick is to commit the patch to your local Mercurial repo before running webrev.
>
> Here's an example of a good one:
>
> http://cr.openjdk.java.net/~aph/8079459/jdk.changeset
>
> Andrew.