RFR: 8166002: Emulate client build on platforms with reduced virtual address space

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Oct 28 18:18:00 UTC 2016


Add comment what the code does and why. Move the code into separate function reaturning bool. And condition CodeCache setting based on result. It will reduce #ifdef mess.

Can you put && to the end of previous line? To get good alignment.
Should we also change CompilationPolicyChoice?

Ask Igor Veresov to verify settings.

Thanks,
Vladimir

On 10/28/16 10:59 AM, Jamsheed C m wrote:
> Hi Vladimir,
>
> revised webrev with just ergo settings for win32.
>
> http://cr.openjdk.java.net/~jcm/8166002/webrev.01/
>
> Best Regards
>
> Jamsheed
>
>
> On 10/28/2016 12:25 PM, Vladimir Kozlov wrote:
>> Hi Jamsheed,
>>
>> Why you need changes in tests?
>>
>> Why you can't use set_client_compilation_mode() in both places?
>>
>> Looks fine otherwise.
>>
>> Thanks,
>> Vladimir
>>
>> On 10/20/16 8:45 AM, Jamsheed C m wrote:
>>> Hi All,
>>>
>>> bug id:https://bugs.openjdk.java.net/browse/JDK-8166002
>>>
>>> http://cr.openjdk.java.net/~jcm/8166002/webrev.00/
>>>
>>> Fix: set NeverActAsServerClassMachine=true, Limit TieredCompilation to C1 by default, for win32 platform.
>>>
>>> A new flag CompilationMode=<client/server> is introduced to select server/ client mode compilation. This option is supported only in TIERED builds.
>>>
>>> -XX:CompilationMode=server supports both -XX:+/-TieredCompilation.
>>>
>>> -XX:CompilationMode:client ignores TieredCompilation flag.
>>>
>>> Please review,
>>>
>>> Best Regards,
>>>
>>> Jamsheed
>>>
>>>
>>>
>


More information about the hotspot-compiler-dev mailing list