[9-dev] Request for review: JDK-8146128: compiler/cpuflags/TestAESIntrinsicsOnSupportedConfig timeouts

[Vladimir Kozlov]

Yes, in addition to timeout increase.

Because we can always find very slow platform (SPARC VM, for example) on 
which any reasonable timeout may be not enough. It would be rare cases 
with increased timeout so that skipping remaining tests is fine, I 
think. You can't increase timeout to hours.

Thanks,
Vladimir

On 9/1/16 11:36 AM, Alexander Vorobyev wrote:
> Do you mean to stop the test execution if there is not enough time
> remained? Even if not all test cases finished?
>
>
> On 01.09.2016 21:15, Vladimir Kozlov wrote:
>> Yes, removing jdk90dev from to:
>>
>> 300 is not enough. From bug report:
>>
>> elapsed time (seconds): 482.214
>>
>> An other way to solve that is to check remaining time after each test
>> (forked VM) is executed and exit gracefully.
>>
>> Thanks,
>> Vladimir
>>
>>
>>
>> On 9/1/16 11:13 AM, Leonid Mesnik wrote:
>>> Hi
>>>
>>> The hotspot compiler changes should go to jdk9/hs-comp and not to 9-dev.
>>> Also hotspot-compiler-dev at openjdk.java.net alias should be used for
>>> compiler specific product and test changes.
>>>
>>> It is unclear from issue description/comment what is the  root cause of
>>> failure and how it was fixed. Could you please add this information.
>>>
>>> Leonid
>>>
>>> On 01.09.2016 20:58, Alexander Vorobyev wrote:
>>>>
>>>> Hi All,
>>>>
>>>> I'd like review for JDK-8146128
>>>> (https://bugs.openjdk.java.net/browse/JDK-8146128)
>>>>
>>>> Test passes with timeout increased. Looks like it times out in
>>>> sub-tests where AESIntrinsics are disabled (testNoUseAES(),
>>>> testNoUseAESIntrinsic()). The easiest way to fix this test is to
>>>> increase timeout.
>>>>
>>>> Run parameter was added:
>>>> @run main/othervm/timeout=300
>>>>
>>>>
>>>> Here is webrev:
>>>> http://cr.openjdk.java.net/~avorobye/8146128/webrev.00/
>>>>
>>>>
>>>> Thanks,
>>>> Alexander
>>>>
>>>>
>>>>
>>>
>