please sponsor? RFR(M): 8165235: [TESTBUG] RTM tests must check OS version

[Lindenmaier, Goetz]

Hi,

This change was reviewed by Volker Simonis and Fillipp Zhinkin.
Final webrevs: 
http://cr.openjdk.java.net/~goetz/wr16/8165235-osRecog/03/webrev.bs/
http://cr.openjdk.java.net/~goetz/wr16/8165235-osRecog/03/webrev.hs/

Could someone please sponsor?

Thanks!
  Goetz

> -----Original Message-----
> From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-
> bounces at openjdk.java.net] On Behalf Of Lindenmaier, Goetz
> Sent: Montag, 5. September 2016 13:55
> To: hotspot-compiler-dev at openjdk.java.net
> Subject: RFR(M): 8165235: [TESTBUG] RTM tests must check OS version
> 
> Hi,
> 
> 
> 
> This fixes the RTM tests wrt. to supported platforms on ppc.
> 
> Please review this change. I please need a sponsor.
> http://cr.openjdk.java.net/~goetz/wr16/8165235-osRecog/01/webrev.bs/
> 
> http://cr.openjdk.java.net/~goetz/wr16/8165235-osRecog/01/webrev.hs/
> 
> 
> RTM uses special instructions that are only available on recent x86 cpus. On
> x86, this feature does not need OS support. On ppc, the equivalent
> functionality, hardware transactional memory, requires OS support. Thus the
> feature is only enabled by the VM if CPU and OS are at a specific level. The
> tests must check this. too. This holds for AIX and Linux.
> 
> 
> 
> To do so, this change introduces rtm/predicate/SupportedOS.java which
> checks for proper OS versions on ppc, else returns true.
> 
> The OS version is retrieved from Platform.java, which has new methods
> getOsVersionMajor() and  getOsVersionMinor().
> 
> To simplify the checks in the tests, I also introduced a 3-way AndPredicate
> constructor.
> 
> 
> 
> To simplify the OS version check on Aix, I change enabling RTM on Aix to
> require AIX 7.2.
> 
> Before, it was enabled on AIX 7.1.3.30, which contains an important bug fix.
> The
> 
> last digits of this version are not exported to os.version property, so I can not
> 
> check for them in the test.
> 
> 
> 
> Best regards,
> 
>   Goetz.