RFR: 8166146 - [Testbug] update codecache tests with minimal vm filter

Igor Ignatyev igor.ignatyev at oracle.com
Thu Sep 15 17:18:58 UTC 2016


The tests have '@modules java.management’, so it’s jtreg responsibilities to filter them out if this module is incompatible/unavailable. I don’t think we should clutter up tests w/ unneeded directives, otherwise you will have to go and update all tests which use modules from compact3+, and you will have to update them again when someone change which modules minimal vm supports. in other words, this should be solved on another level: test execution system, test harness, wherever but in not tests. they already declared everything they depend on.

Thanks,
— Igor

> On Sep 15, 2016, at 8:12 PM, Dmitrij Pochepko <dmitrij.pochepko at oracle.com> wrote:
> 
> Hi,
> 
> these tests are using java.management module, which is incompatible with minimal vm(even if this modules is present in tested image).
> 
> Thanks,
> Dmitrij
>> Dmitrij,
>> 
>> could you please explain why those tests are applicable for minimal vm?
>> 
>> Thanks,
>> — Igor
>> 
>>> On Sep 15, 2016, at 7:57 PM, Dmitrij Pochepko <dmitrij.pochepko at oracle.com> wrote:
>>> 
>>> Hi,
>>> 
>>> please  review small fix for 8166146 - [Testbug] update codecache tests with minimal vm filter
>>> 
>>> This patch update codecache tests which are not applicable for minimal vm with respective requires expression
>>> 
>>> 
>>> webrev: http://cr.openjdk.java.net/~dpochepk/8166146/webrev.01/
>>> 
>>> CR: https://bugs.openjdk.java.net/browse/JDK-8166146
>>> 
>>> I've tested this change on linux-x86 using minimal vm
>>> 
>>> 
>>> Thanks,
>>> 
>>> Dmitrij
>>> 
> 



More information about the hotspot-compiler-dev mailing list