RFR(XS) : 8166164 : compiler/compilercontrol/share/processors/LogProcessor.java does not close Scanner

Pavel Punegov pavel.punegov at oracle.com
Mon Sep 19 12:18:24 UTC 2016


Hi Igor,

the change looks good. Thanks for fixing.

— Pavel.

> On 19 Sep 2016, at 12:38, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~iignatyev/8166164/webrev.00/
>> 16 lines changed: 2 ins; 0 del; 14 mod;
> 
> Hi all,
> 
> could you please review this small patch which fixes resource leak in compiler/compilercontrol tests? 
> LogProcessor::getScanner creates a new Scanner, but there is no code which closes it. This leak leads to 'failed to clean up files after test’ error from jtreg.
> 
> the fix was tested by running :hotspot_compiler test group.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8166164
> webrev: http://cr.openjdk.java.net/~iignatyev/8166164/webrev.00/
> 
> Thanks,
> — Igor
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160919/0337df60/attachment.html>


More information about the hotspot-compiler-dev mailing list