RFR(XS) : 8166164 : compiler/compilercontrol/share/processors/LogProcessor.java does not close Scanner

Igor Ignatyev igor.ignatyev at oracle.com
Tue Sep 20 14:36:55 UTC 2016


Vladimir,

thank you for review.

— Igor

> On Sep 19, 2016, at 8:26 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Good.
> 
> thanks,
> Vladimir
> 
> On 9/19/16 2:38 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8166164/webrev.00/
>>> 16 lines changed: 2 ins; 0 del; 14 mod;
>> 
>> Hi all,
>> 
>> could you please review this small patch which fixes resource leak in compiler/compilercontrol tests?
>> LogProcessor::getScanner creates a new Scanner, but there is no code which closes it. This leak leads to 'failed to clean up files after test’ error from jtreg.
>> 
>> the fix was tested by running :hotspot_compiler test group.
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8166164
>> webrev: http://cr.openjdk.java.net/~iignatyev/8166164/webrev.00/
>> 
>> Thanks,
>> — Igor
>> 



More information about the hotspot-compiler-dev mailing list