Request for review: JDK-8145728: compiler/cpuflags/TestAESIntrinsicsOnSupportedConfig.java Expected message not found: 'com.sun.crypto.provider.AESCrypt::(implEncryptBlock|implDecryptBlock) ([0-9]+ bytes) (intrinsic) not found on supported platfroms

[Alexander Vorobyev]

Do you mean with -XX:+TieredCompilation -XX:TieredStopAtLevel=1? There 
are no reports about such failures - all other compiler/cpuflags tests 
pass judging by existing test runs results. Just in case, I run 
compiler/cpuflags tests manually - no failures.


On 29.09.2016 19:38, Vladimir Kozlov wrote:
> Looks good. Did you run all compiler/cpuflags tests to verify that we 
> don't need to fix other tests too?
>
> Thanks,
> Vladimir
>
> On 9/29/16 9:30 AM, Alexander Vorobyev wrote:
>>
>> Hi All,
>>
>> I'd like review for JDK-8145728
>> (https://bugs.openjdk.java.net/browse/JDK-8145728)
>>
>> Judging by the test results, test fails with specific compiler options:
>> -XX:+TieredCompilation -XX:TieredStopAtLevel=N, where N<4. In this case
>> C2 is not used and we are not able to see intrinsics usage in the test
>> log. So such configuration is not valid for this test and should not be
>> used. Supposed fix is to prevent this test from accepting such options.
>>
>> "@requires" tag was added:
>> @requires vm.opt.TieredStopAtLevel == null | vm.opt.TieredStopAtLevel 
>> == 4
>>
>>
>> Here is webrev:
>> http://cr.openjdk.java.net/~avorobye/8145728/webrew.00/
>>
>>
>> Thanks,
>> Alexander
>>
>>
>>