RFR:8166684:implement intrinsic code with vector instructions for Unsafe.copyMemory()

[Doerr, Martin]

Hi Michihiro,

thanks for contributing this change. Looks good, now. We will test it.
We’ll push it if it gets approved and reviewed.

Best regards,
Martin

From: Michihiro Horie [mailto:HORIE at jp.ibm.com]
Sent: Freitag, 30. September 2016 15:31
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Cc: gromero at linux.vnet.ibm.com; Hiroshi H Horii <HORII at jp.ibm.com>; Doerr, Martin <martin.doerr at sap.com>; ppc-aix-port-dev at openjdk.java.net; Simonis, Volker <volker.simonis at sap.com>; hotspot-compiler-dev at openjdk.java.net
Subject: Re: RE: RFR:8166684:implement intrinsic code with vector instructions for Unsafe.copyMemory()

Hi Goetz, Martin,

Would you review this? The initialization of tmp1 is now outside the loop.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8166684
Webrev: http://cr.openjdk.java.net/~horii/8166684/webrev.01/

We created webrev by ourselves, and cced to hotspot-compiler-dev.

Best regards,
--
Michihiro,
IBM Research - Tokyo


----- Original message -----
From: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>
To: "Doerr, Martin" <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>, Michihiro Horie/Japan/IBM at IBMJP, "Simonis, Volker" <volker.simonis at sap.com<mailto:volker.simonis at sap.com>>, "ppc-aix-port-dev at openjdk.java.net<mailto:ppc-aix-port-dev at openjdk.java.net>" <ppc-aix-port-dev at openjdk.java.net<mailto:ppc-aix-port-dev at openjdk.java.net>>
Cc: Hiroshi H Horii/Japan/IBM at IBMJP, Gustavo Romero <gromero at linux.vnet.ibm.com<mailto:gromero at linux.vnet.ibm.com>>
Subject: RE: RFR:8166684:implement intrinsic code with vector instructions for Unsafe.copyMemory()
Date: Mon, Sep 26, 2016 10:51 PM

Hi,

please post this RFR also to hotspot-compiler-dev. It must be reviewed
on one of the official lists before it can be pushed. Ppc-aix-port-dev
is only for communication about the port, not for reviews.

Also I would appreciate if you could upload your webrevs yourselves.
We are happy to help out in the beginning, and also with testing,
reviewing and pushing, but making webrevs is a task I don't see on
our side in the long term.

Thanks and best regards,
  Goetz.

> -----Original Message-----
> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> bounces at openjdk.java.net<mailto:bounces at openjdk.java.net>] On Behalf Of Doerr, Martin
> Sent: Montag, 26. September 2016 11:53
> To: Michihiro Horie <HORIE at jp.ibm.com<mailto:HORIE at jp.ibm.com>>; Simonis, Volker
> <volker.simonis at sap.com<mailto:volker.simonis at sap.com>>; ppc-aix-port-dev at openjdk.java.net<mailto:ppc-aix-port-dev at openjdk.java.net>
> Cc: Hiroshi H Horii <HORII at jp.ibm.com<mailto:HORII at jp.ibm.com>>; Gustavo Romero
> <gromero at linux.vnet.ibm.com<mailto:gromero at linux.vnet.ibm.com>>
> Subject: RE: RFR:8166684:implement intrinsic code with vector instructions
> for Unsafe.copyMemory()
>
> Hi Michihiro,
>
>
>
> the initialization of tmp1 should be done outside of the loop. Beside that, the
> change looks good:
>
> http://cr.openjdk.java.net/~mdoerr/8166684_PPC64_unsafe_copymemory/
> webrev.00/
> <http://cr.openjdk.java.net/~mdoerr/8166684_PPC64_unsafe_copymemory
> /webrev.00/>
>
>
>
> Best regards,
>
> Martin
>
>
>
>
>
> From: Michihiro Horie [mailto:HORIE at jp.ibm.com]
> Sent: Montag, 26. September 2016 09:37
> To: Doerr, Martin <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>; Simonis, Volker
> <volker.simonis at sap.com<mailto:volker.simonis at sap.com>>; ppc-aix-port-dev at openjdk.java.net<mailto:ppc-aix-port-dev at openjdk.java.net>
> Cc: volker.simonis at gmail.com<mailto:volker.simonis at gmail.com>; Gustavo Romero
> <gromero at linux.vnet.ibm.com<mailto:gromero at linux.vnet.ibm.com>>; Hiroshi H Horii <HORII at jp.ibm.com<mailto:HORII at jp.ibm.com>>
> Subject: RFR:8166684:implement intrinsic code with vector instructions for
> Unsafe.copyMemory()
>
>
>
> Dear all,
>
> Could I please request reviews for the following change?
> This change was created for JDK9.
>
> I added fixes to the intrinsic code for sun.misc.Unsafe.copyMemory() by
> using VSX.
> Since Spark often invokes Unsafe.copyMemory(), it is beneficial to use the
> vector instructions for these intrinsic code.
>
> jira: https://bugs.openjdk.java.net/browse/JDK-8166684
> <https://bugs.openjdk.java.net/browse/JDK-8166684>
> diff: (See attached file: unsafe-copymemory-openjdk9.diff)
>
> Best regards,
> --
> Michihiro Horie,
> IBM Research - Tokyo



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160930/ad2d8da6/attachment-0001.html>