[10] RFR: 8171813: possible null pointer dereference defects

[Zoltán Majó]

Hi Rahul,


On 04/06/2017 08:27 AM, Rahul Raghavan wrote:
> Hi,
>
> Thank you Tobias for the review comments.
> Sorry for my oversight and yes now included the required changes.
>
> <webrev.01> - http://cr.openjdk.java.net/~rraghavan/8171813/webrev.01/
> Believe the changes are now okay to be committed.

your change looks good to me. Thank you!

Best regards,


Zoltan

>
> Thanks,
> Rahul
>
>> -----Original Message-----
>> From: Tobias Hartmann
>> Sent: Monday, April 03, 2017 11:53 AM
>> To: Rahul Raghavan; hotspot-compiler-dev at openjdk.java.net; Vladimir Kozlov; Zoltan Majo
>> Subject: Re: [10] RFR: 8171813: possible null pointer dereference defects
>>
>> Hi Rahul,
>>
>> On 31.03.2017 17:48, Rahul Raghavan wrote:
>>> Please review following patch proposal to avoid
>>> possible null pointer dereference warnings / errors for internal tests.
>>>
>>> <webrev.00> - http://cr.openjdk.java.net/~rraghavan/8171813/webrev.00/
>> Please compare against NULL instead of casting to bool, i.e. use "if (compiler != NULL)" instead of "if (compiler)".
>>
>> In simpleThresholdPolicy.inline.hpp:80, please move the * to the type: use "AbstractCompiler* comp" instead of "AbstractCompiler
>> *comp".
>>
>> Thanks,
>> Tobias