RFR 8150388: Remove SPARC 32-bit support
Gerald Thornbrugh
gerald.thornbrugh at oracle.com
Fri Apr 7 16:18:15 UTC 2017
Hi George,
Wow, this is bigger than I thought it would be.
A couple of questions:
I assume you will update the copyright years before you putback?
src <https://grok.cz.oracle.com/source/xref/jdk9/hotspot/src/>/os_cpu <https://grok.cz.oracle.com/source/xref/jdk9/hotspot/src/os_cpu/>/solaris_sparc <https://grok.cz.oracle.com/source/xref/jdk9/hotspot/src/os_cpu/solaris_sparc/>/vm <https://grok.cz.oracle.com/source/xref/jdk9/hotspot/src/os_cpu/solaris_sparc/vm/>/atomic_solaris_sparc.hpp <https://grok.cz.oracle.com/source/xref/jdk9/hotspot/src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.hpp>
Line 245, you can probably remove the " || defined(_LP64)”
Line 372, you can probably remove the "_LP64 ||”
Is there a reason you did not include prefetch_solaris_sparc.inline.hpp in your changes?
src <https://grok.cz.oracle.com/source/xref/jdk9/hotspot/src/>/os_cpu <https://grok.cz.oracle.com/source/xref/jdk9/hotspot/src/os_cpu/>/solaris_sparc <https://grok.cz.oracle.com/source/xref/jdk9/hotspot/src/os_cpu/solaris_sparc/>/vm <https://grok.cz.oracle.com/source/xref/jdk9/hotspot/src/os_cpu/solaris_sparc/vm/>/prefetch_solaris_sparc.inline.hpp <https://grok.cz.oracle.com/source/xref/jdk9/hotspot/src/os_cpu/solaris_sparc/vm/prefetch_solaris_sparc.inline.hpp>
Line 30, 58 and 63, you can probably remove the references to _LP64
Is there a plan to remove the SPARC 32 bit support from the makefiles and build configuration files?
Thanks!
Jerry
> On Apr 7, 2017, at 8:47 AM, George Triantafillou <george.triantafillou at oracle.com> wrote:
>
> (Adding compiler).
>
> Please review this fix to remove SPARC 32-bit support. Support for solaris-sparc has been dropped from the list of supported platforms.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8150388
> webrev: http://cr.openjdk.java.net/~gtriantafill/8150388-webrev/webrev/ <http://cr.openjdk.java.net/%7Egtriantafill/8150388-webrev/webrev/>
>
> Built and tested on solaris-sparcv9-debug,solaris-x64-debug with the nsk.jvmti, nsk.jdwp, and nsk.jdi testlists.
>
> Thanks.
>
> -George
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20170407/ac1dc7ca/attachment.html>
More information about the hotspot-compiler-dev
mailing list