RFR(S) : 8178835: CTW Runner should check that all classes have been compiled

Igor Ignatyev igor.ignatyev at oracle.com
Wed Apr 19 03:11:48 UTC 2017


Vladimir,

Thank you for the review!
-- Igor 
> On Apr 18, 2017, at 4:36 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Okay.
> 
> Vladimir
> 
> On 4/18/17 3:49 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8178835/webrev.00/index.html
>>> 99 lines changed: 88 ins; 1 del; 10 mod
>> 
>> Hi all,
>> 
>> could you please review this small fix for CTW runner which adds verification that CTW was run for all classes?
>> currently, CTW runner stops execution when a child process exits w/ zero code, this might lead to missed test cover and/or false negative tests results. This fix adds a check that the index of the last compiled class equals to count of classes in a target.
>> 
>> webrev: http://cr.openjdk.java.net/~iignatyev//8178835/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8178835
>> testing: applications/ctw
>> 
>> Thanks,
>> -- Igor
>> 



More information about the hotspot-compiler-dev mailing list