RFR: 8177845: Need a mechanism to load Graal
Mandy Chung
mandy.chung at oracle.com
Thu Apr 27 21:24:44 UTC 2017
> On Apr 27, 2017, at 7:47 AM, Doug Simon <doug.simon at oracle.com> wrote:
>
> [1] http://cr.openjdk.java.net/~dnsimon/8177845.02
I reviewed the top repo and jdk repo change. For hotspot change,
I reviewed jdk.vm.ci.services/* and jdk.internal.vm.ci module-info.java.
make/make/CompileJavaModules.gmk
jdk/make/launcher/Launcher-jdk.aot.gmk
Reading the original jdk.internal.vm.ci module-info.java [1],
jdk.aot only accesses a small set of packages. e.g. it does not
access jdk.vm.ci.aarch64, jdk.vm.ci.code.stack, jdk.vm.ci.common, etc.
115 jdk.internal.vm.compiler \
This should be removed from PLATFORM_MODULES list. $PLATFORM_MODULES
already includes $UPGRADEABLE_MODULES.
Otherwise, looks good to me.
There are jdk tests verifying upgradeable modules and qualified exports.
I suggest to run through JPRT -testset core options to catch any test failure.
Mandy
[1] http://cr.openjdk.java.net/~dnsimon/8177845.02/hotspot/src/jdk.internal.vm.ci/share/classes/module-info.java.sdiff.html
More information about the hotspot-compiler-dev
mailing list