RFR(S) : 8185536 : @key aot should be replaced w/ @requires vm.aot

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Aug 2 12:49:36 UTC 2017


Hi Igor, 

the change is looking good.

A small thing, I would spell vmAot() as vmAOT(), all abbreviations
(except for Jvmci) are capitalized here.

It passed the tests on all platforms that have been running so far.
(Some had an unrelated issue tonight).

Best regards,
  Goetz.

> -----Original Message-----
> From: Igor Ignatyev [mailto:igor.ignatyev at oracle.com]
> Sent: Dienstag, 1. August 2017 17:51
> To: hotspot-compiler-dev at openjdk.java.net compiler <hotspot-compiler-
> dev at openjdk.java.net>
> Cc: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Subject: RFR(S) : 8185536 : @key aot should be replaced w/ @requires
> vm.aot
> 
> http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
> > 81 lines changed: 19 ins; 0 del; 62 mod
> 
> Hi all,
> 
> could you please review this small patch which introduces 'vm.aot' property
> into jtreg @requires context and replaces all '@key aot' added by 8185046[1]
> w/ '@requiers vm.aot'?
> Goetz(author of 8185046) is checking that it works for their configurations.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8185536
> webrev:
> http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
> testing: hotspot/test/compiler/aot tests
>  - on linux-x64 : 56 tests selected/run
>  - on linux-x86 : 0 tests selected/run
>  - on windows-x64 (after remove tests from problemlist) : 56 tests
> selected/run
>  - on windows-x86 (after remove tests from problemlist) : 0 tests
> selected/run
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8185046
> 
> Thanks,
> -- Igor


More information about the hotspot-compiler-dev mailing list