compiler/jvmci/compilerToVM/HasCompiledCodeForOSRTest.java fails with Graal
Christian Thalinger
cthalinger at twitter.com
Fri Aug 11 09:16:53 UTC 2017
> On Jun 27, 2017, at 7:20 PM, Doug Simon <doug.simon at oracle.com> wrote:
>
>
>> On 27 Jun 2017, at 18:34, Christian Thalinger <cthalinger at twitter.com> wrote:
>>
>>>
>>> On Jun 26, 2017, at 8:47 PM, Doug Simon <doug.simon at oracle.com> wrote:
>>>
>>>
>>>> On 27 Jun 2017, at 01:37, Christian Thalinger <cthalinger at twitter.com> wrote:
>>>>
>>>> So, this change:
>>>>
>>>> $ hg log -r fbb9c8026495 -p compiler/jvmci/compilerToVM/HasCompiledCodeForOSRTest.java
>>>> changeset: 12748:fbb9c8026495
>>>> tag: jdk-9+168
>>>> user: dnsimon
>>>> date: Fri Apr 28 02:54:05 2017 -0700
>>>> summary: 8177845: Need a mechanism to load Graal
>>>>
>>>> diff --git a/test/compiler/jvmci/compilerToVM/HasCompiledCodeForOSRTest.java b/test/compiler/jvmci/compilerToVM/HasCompiledCodeForOSRTest.java
>>>> --- a/test/compiler/jvmci/compilerToVM/HasCompiledCodeForOSRTest.java
>>>> +++ b/test/compiler/jvmci/compilerToVM/HasCompiledCodeForOSRTest.java
>>>> @@ -39,7 +39,7 @@
>>>> * @run main/othervm -Xbootclasspath/a:.
>>>> * -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI
>>>> * -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI
>>>> - * -XX:-BackgroundCompilation
>>>> + * -XX:-BackgroundCompilation -Djvmci.Compiler=null
>>>> * compiler.jvmci.compilerToVM.HasCompiledCodeForOSRTest
>>>> */
>>>>
>>>>
>>>> sets the JVMCI compiler to null. How is this test supposed to work when running with UseJVMCICompiler and Graal?
>>>
>>> It's not which is why the flags needed to enable Graal aren't present.
>>
>> But what if you run with -vmoptions:”-XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:+UseJVMCICompiler”? Which is what you do when you want to run all tests with Graal.
>
> Then I guess the test will have to be modified/fixed.
Has anyone filed a bug and/or picked this up?
More information about the hotspot-compiler-dev
mailing list