RFR: 8186459: [JVMCI] ClassNotFoundException thrown by CompilerToVM.lookupType() should be converted to a LinkageError

[Vladimir Kozlov]

Should tests be fixed as part of 8186136?

Vladimir

https://bugs.openjdk.java.net/browse/JDK-8186136

On 8/23/17 1:58 PM, Doug Simon wrote:
> Thanks Igor.
> 
> I just ran jtreg locally which showed that I need to also fix a number of tests to account for the new checked exception. I also took the liberty of removing `-Djvmci.Compiler=null` from the tests I modified to remove the `jdk.vm.ci.common.JVMCIError: no JVMCI compiler selected` noise.
> 
> Please check that the test changes look ok.
> 
> -Doug
> 
>> On 23 Aug 2017, at 19:28, Igor Veresov <igor.veresov at oracle.com> wrote:
>>
>> Looks good.
>>
>> igor
>>
>>> On Aug 23, 2017, at 8:14 AM, Doug Simon <doug.simon at oracle.com> wrote:
>>>
>>> Can I please get one more review on this RFR.
>>>
>>> -Doug
>>>
>>>> On 18 Aug 2017, at 23:57, Doug Simon <doug.simon at oracle.com> wrote:
>>>>
>>>>
>>>>> On 18 Aug 2017, at 23:58, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>>>>
>>>>> On 8/18/17 2:49 PM, Doug Simon wrote:
>>>>>> It seems easier to do the exception handling in Java and I'm not sure I see a disadvantage to doing it there?
>>>>>
>>>>> :) I am C++ guy.
>>>>
>>>> I need to assign more Graal bugs to you to fix that ;-)
>>>>
>>>>>
>>>>> Okay.
>>>>>
>>>>> Thanks,
>>>>> Vladimir
>>>>>
>>>>>> -Doug
>>>>>>> On 18 Aug 2017, at 23:41, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>>>>>>
>>>>>>> Should you change C++ part of JVMCI instead and check PENDING_EXCEPTION like next?
>>>>>>>
>>>>>>> http://hg.openjdk.java.net/jdk10/hs/hotspot/file/c8607c55bfda/src/share/vm/oops/method.cpp#l1573
>>>>>>>
>>>>>>> or call SystemDictionary::resolve_or_fail() instead of resolve_or_null()?:
>>>>>>>
>>>>>>> http://hg.openjdk.java.net/jdk10/hs/hotspot/file/c8607c55bfda/src/share/vm/classfile/systemDictionary.cpp#l191
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Vladimir
>>>>>>>
>>>>>>> On 8/18/17 1:32 PM, Doug Simon wrote:
>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8186459
>>>>>>>> http://cr.openjdk.java.net/~dnsimon/8186459/
>>>>>>>> -Doug
>>>>
>>>
>>
>