[10] RFR(XS) 8186721: AOT tests fail with: section alignment is not valid: 128

[Vladimir Kozlov]

https://bugs.openjdk.java.net/browse/JDK-8186721

Fixed typo in assert code in JDK-8186453 changes - I missed '!' negation:

src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/PECoffSection.java
@@ -50,7 +50,7 @@
          byte[] Name = sectName.getBytes();
          int max = Name.length <= IMAGE_SECTION_HEADER.Name.sz ? 
Name.length : IMAGE_SECTION_HEADER.Name.sz;

-        assert (sectAlign < 1 || sectAlign > 1024 || (sectAlign & 
(sectAlign - 1)) != 0) : "section alignment is not valid: " + sectAlign;
+        assert !(sectAlign < 1 || sectAlign > 1024 || (sectAlign & 
(sectAlign - 1)) != 0) : "section alignment is not valid: " + sectAlign;
          align = sectAlign;

          // Using 32 because IMAGE_SCN_ALIGN_*BYTES is value + 1

test/compiler/aot/AotCompiler.java	Thu Aug 24 09:29:56 2017 -0700
@@ -113,6 +113,9 @@
              args.add("--linker-path");
              args.add(linker);
          }
+        // Execute with asserts
+        args.add("-J-ea");
+        args.add("-J-esa");
          return launchJaotc(args, extraopts);
      }

We should run our JVMCI and AOT tests with -ea -esa so that problem like 
this do not slip through JPRT and normal testing. I created JDK-8186747 
for that.

For this bug fix I added -ea -esa for few AOT tests which use 
AotCompiler class to run jaotc.

Thanks,
Vladimir