[10] RFR(s) 8186136: [Graal] some tests setting -Djvmci.Compiler=null fail with: jdk.vm.ci.common.JVMCIError: no JVMCI compiler selected

[Vladimir Kozlov]

I opened 8146528. It was filed before AOT become opened.
I think we should treat Graal's methods separately in -Xcomp case.

Vladimir

On 8/24/17 4:42 PM, Christian Thalinger wrote:
> 
>> On Aug 24, 2017, at 1:39 PM, Vladimir Kozlov 
>> <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>> wrote:
>>
>> On 8/24/17 4:31 PM, Christian Thalinger wrote:
>>>> On Aug 24, 2017, at 12:55 PM, Vladimir Kozlov 
>>>> <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>> wrote:
>>>>
>>>> Thank you, Chris
>>>>
>>>> With -TieredCompilation I found other tests need to fix:
>>>>
>>>> compiler/jvmci/compilerToVM/IsMatureVsReprofileTest.java
>>>> compiler/jvmci/compilerToVM/ReprofileTest.java
>>>>
>>>> And next test needs to be fixed too. I missed it because it is on 
>>>> problem list and failed in all configurations:
>>>>
>>>> compiler/jvmci/compilerToVM/InvalidateInstalledCodeTest.java
>>>>
>>>> The rest tests do not do JIT compilation
>>> Trying not to mention -Xcomp :-)
>>
>> You already filed bug for that ;)
> 
> I did?
> 
>>
>> https://bugs.openjdk.java.net/browse/JDK-8146528
> 
> "Permission violation”
> 
>>
>>>> or don't have -Djvmci.Compiler flag. They passed in all configuration.
>>> I think that’s good enough for now.
>>
>> Thank you, Chris
>>
>> Vladimir
>>
>>>>
>>>> There are other test problem 8186144 which I am working on too.
>>>>
>>>> I updated webrev:
>>>>
>>>> http://cr.openjdk.java.net/~kvn/8186136/webrev.01/
>>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>>
>>>> On 8/24/17 11:52 AM, Christian Thalinger wrote:
>>>>>> On Aug 24, 2017, at 7:48 AM, Vladimir Kozlov 
>>>>>> <vladimir.kozlov at oracle.com> wrote:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~kvn/8186136/webrev/
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8186136
>>>>>>
>>>>>> I think most of jvmci tests do not need '-Djvmci.Compiler=graal' 
>>>>>> for execution - using -Djvmci.Compiler=null is correct thing. We 
>>>>>> reduce testing time if we don't load Graal.
>>>>>>
>>>>>> Only test which do compilation and need JIT compiler are fixed for 
>>>>>> the case when Graal is JIT compiler.
>>>>> But isn’t that a timing issue?  What if tests are run with 
>>>>> -TieredCompilation?
>>>>>> I also fixed JVM_GetJVMCIRuntimeTest.java for JDK-8186144 - added 
>>>>>> -XX:-UseJVMCICompiler for -XX:-EnableJVMCI case.
>>>>>>
>>>>>> RBT tested and local test with both, default JIT and Graal JIT.
>>>>>>
>>>>>> Thanks,
>>>>>> Vladimir
>