JDK10/RFR(L): 8167199: Add C2 SPARC intrinsic for BigInteger::multiplyToLen() method.
Vladimir Kozlov
vladimir.kozlov at oracle.com
Tue Aug 29 16:43:34 UTC 2017
On 8/29/17 2:22 AM, Nils Eliasson wrote:
> Hi Patric,
>
> Looks good.
+1
>
> Just make sure this code path is covered in the regular testing.
There are jtreg multiplytolen tests. Make sure they run on SPARC.
You can also run jvm2008 crypto sub-benchmarks.
Thanks,
Vladimir
>
> Regards,
>
> Nils
>
>
> On 2017-08-28 15:06, Patric Hedlin wrote:
>> Dear all,
>>
>> I would like to ask for help to review the following change/update:
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8167199
>>
>> Webrev: http://cr.openjdk.java.net/~phedlin/tr8167199/
>>
>>
>> 8167199: Add C2 SPARC intrinsic for BigInteger::multiplyToLen() method.
>>
>> Added C2 SPARC support for intrinsic 'multiplyToLen', including
>> generalised version based on 'mpmul' instruction (when available).
>> The code emitted should be subject for evaluation (e.g. MME on
>> SPARC Core C5 might be used in an improved version).
>>
>> Testing:
>>
>> Mostly tested on JDK9 (jtreg/RBT/hotspot/tier0-comp).
>> Testing on JDK10 (jtreg/RBT/hotspot/precheckin-comp).
>>
>>
>> Best regards,
>> Patric
>
More information about the hotspot-compiler-dev
mailing list