RFR(XS) : 8187020 : AOT tests should not fail if devkit dependency isn't resolved

Bob Vandette bob.vandette at oracle.com
Thu Aug 31 19:14:21 UTC 2017


The change looks ok to me.

Bob.

> On Aug 31, 2017, at 2:02 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~iignatyev//8187020/webrev.00/index.html
>> 11 lines changed: 5 ins; 0 del; 6 mod;
> 
> Hi all,
> 
> could you please review this tiny fix or AOT tests? Prior this fix, the tests would fail w/ FileNotFoundException when devkit dependency can't be resolved even if jaotc is able to find a linker, e.g. in one of VS*COMNTOOLS. after this fix, if tests aren't able to download devkit, they will allow jaotc to try to find a linker. This patch also remove search for 'ld' in PATH on windows b/c jaotc doesn't use it on windows.
> 
> webrev: http://cr.openjdk.java.net/~iignatyev//8187020/webrev.00/index.html
> jbs: https://bugs.openjdk.java.net/browse/JDK-8187020
> testing: compiler/aot tests
> 
> Thanks,
> -- Igor



More information about the hotspot-compiler-dev mailing list