RFR(XS) 8193323: Crash in "failed dependencies, but counter didn't change" with enabled UseJVMCICompiler

[Vladimir Kozlov]

Okay.

Vladimir

On 12/13/17 10:47 AM, dean.long at oracle.com wrote:
> Updated webrev:
> 
> http://cr.openjdk.java.net/~dlong/8193323/webrev.1/
> 
> 
> I fixed the embarrassing typo I introduced:
> 
> 
> *** jvmciCompilerToVM.cpp    2017-12-13 09:18:43.000000000 -0800
> --- src/hotspot/share/jvmci/jvmciCompilerToVM.cpp 2017-12-13 
> 10:32:40.996389329 -0800
> ***************
> *** 765,771 ****
>      if (method->is_old()) {
>        return false;
>      }
> !   return method->is_not_compilable(CompLevel_full_optimization);
>    C2V_END
> 
>    C2V_VMENTRY(jboolean, hasNeverInlineDirective,(JNIEnv *, jobject, 
> jobject jvmci_method))
> --- 765,771 ----
>      if (method->is_old()) {
>        return false;
>      }
> !   return !method->is_not_compilable(CompLevel_full_optimization);
>    C2V_END
> 
>    C2V_VMENTRY(jboolean, hasNeverInlineDirective,(JNIEnv *, jobject, 
> jobject jvmci_method))
> 
> Originally I had
> 
>      return !method->is_old() && 
> !method->is_not_compilable(CompLevel_full_optimization);
> 
> 
> but I split the condition so I could add a comment and somehow lost the 
> "!" operator.
> 
> I started a new batch of tests.
> 
> dl
> 
> On 12/13/17 10:12 AM, dean.long at oracle.com wrote:
>> I'm seeing some test failures that I need to investigate.  I may need 
>> to post an updated webrev.
>>
>> dl
>>
>>
>> On 12/13/17 9:50 AM, Vladimir Kozlov wrote:
>>> Looks good.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 12/13/17 9:44 AM, dean.long at oracle.com wrote:
>>>> Sorry, I forgot to fill in the subject line correctly last time.
>>>>
>>>>
>>>> On 12/13/17 9:41 AM, dean.long at oracle.com wrote:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8193323
>>>>> http://cr.openjdk.java.net/~dlong/8193323/webrev
>>>>>
>>>>> JVMCI needs to skip redefined methods like C1 and C2.
>>>>>
>>>>> dl
>>>>
>>
>