RFR(XS) 8173673: Fix comparison input types in GraalHotSpotVMConfigNode.inlineContiguousAllocationSupported()

Igor Veresov igor.veresov at oracle.com
Mon Feb 6 20:04:52 UTC 2017


The change got a bit bigger after the reviews on GitHub.
So, I’m revising the webrev: http://cr.openjdk.java.net/~iveresov/8173673/webrev.01/
Relevant discussion here: https://github.com/graalvm/graal-core/pull/249

Thanks,
igor

> On Jan 31, 2017, at 9:14 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Good.
> 
> Thanks,
> Vladimir
> 
> On 1/30/17 11:10 PM, Igor Veresov wrote:
>> In GraalHotSpotVMConfigNode.inlineContiguousAllocationSupported() we need a cast because loadConfigValue() returns a long, but the node it produces has an int type. It triggers an assert.
>> 
>> Webrev: http://cr.openjdk.java.net/~iveresov/8173673/webrev.00/
>> 
>> 
>> Thanks,
>> igor
>> 



More information about the hotspot-compiler-dev mailing list