RFR (S) 8175887: C1 value numbering handling of Unsafe.get*Volatile is incorrect

Aleksey Shipilev shade at redhat.com
Tue Feb 28 19:08:59 UTC 2017


On 02/28/2017 08:06 PM, Vladimir Ivanov wrote:
> On 2/28/17 7:42 PM, Vladimir Ivanov wrote:
>>> All right, fine:
>>>   http://cr.openjdk.java.net/~shade/8175887/webrev.03/
>>
>> Thanks, looks good.
> 
> FYI spotted a couple of issues in the tests. Once the testing is over I plan to
> push the following version (w/ some cleanups):
>  http://cr.openjdk.java.net/~vlivanov/shade/8175887/

The cleanup look good, but are you sure AssertionError would get reported from
the thread, and it would not silently die? The original test exited hard to
handle this.

Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20170228/60bba676/signature.asc>


More information about the hotspot-compiler-dev mailing list