RFR: 8171082: [AOT] AOT'd SystemModules.modules() fails to load when too large

Rickard Bäckman rickard.backman at oracle.com
Tue Jan 3 08:16:14 UTC 2017


Thanks for the review Vladimir.

I added the line and sent the patch of to jprt.

/R

On 01/02, Vladimir Kozlov wrote:
> Thank you, Rickard, for fixing this.
> 
> It is really unfortunate that we put code method's aot into code
> buffer before we process its metadata when do AOT compilation.
> 
> One thing we can additionally do is mark a method as invalid if publish_aot() does not publish it:
> 
> _code_to_aot[code_id]._state = invalid
> 
> Thanks,
> Vladimir
> 
> On 1/2/17 5:37 AM, Rickard Bäckman wrote:
> >Can I please have reviews for this small change?
> >
> >When generating metadata for AOT compiled method we don't need to
> >consider the size of the method. I added a parameter to the method so it
> >doens't fail for that case, but still fail when called through the
> >install method that JVMCI use for installing methods into the CodeCache.
> >
> >https://bugs.openjdk.java.net/browse/JDK-8171082
> >http://cr.openjdk.java.net/~rbackman/8171082/
> >
> >Thanks
> >/R
> >


More information about the hotspot-compiler-dev mailing list