RFR(XS): x86: 8171974: Fix for R10 Register clobbering with usage of ExternalAddress

Deshpande, Vivek R vivek.r.deshpande at intel.com
Tue Jan 3 21:26:00 UTC 2017


Hi

I have updated the webrev with the suggested change.
Please find the webrev here:
http://cr.openjdk.java.net/~vdeshpande/8171974/webrev.01/
Thank you.

Regards,
Vivek
-----Original Message-----
From: Rickard Bäckman [mailto:rickard.backman at oracle.com] 
Sent: Monday, January 02, 2017 5:54 AM
To: Deshpande, Vivek R
Cc: hotspot-compiler-dev at openjdk.java.net; Vladimir Kozlov; Viswanathan, Sandhya
Subject: Re: RFR(XS): x86: 8171974: Fix for R10 Register clobbering with usage of ExternalAddress


macroAssembler_x86.cpp & macroAssembler_x86.hpp  Please don't use scr as a variable name, scratch is probably better if  that is what it is? scr and src are too similar.

/R

On 12/23, Deshpande, Vivek R wrote:
> Hi
> 
> I have bug fix for R10 Register clobbering with usage of ExternalAddress in the instructions.
> Webrev for the fix:
> http://cr.openjdk.java.net/~vdeshpande/8171974/webrev.00/
> I have also updated the JBS entry.
> https://bugs.openjdk.java.net/browse/JDK-8171974
> Would you please review and sponsor it.
> 
> Regards,
> Vivek
> 


More information about the hotspot-compiler-dev mailing list