RFR(XS): 8172199: s390: Use same get_key_start_from_aescrypt_object implementation as PPC64

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Jan 4 19:33:10 UTC 2017


Vladimir, thanks for sponsoring my change, and Martin thanks for reviewing!

Best regards,
  Goetz

> -----Original Message-----
> From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-
> bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
> Sent: Dienstag, 3. Januar 2017 20:17
> To: Doerr, Martin <martin.doerr at sap.com>; 'hotspot-compiler-
> dev at openjdk.java.net' <hotspot-compiler-dev at openjdk.java.net>
> Subject: Re: RFR(XS): 8172199: s390: Use same
> get_key_start_from_aescrypt_object implementation as PPC64
> 
> Okay, I will push them together since they only added #ifdef s390 into
> shared code and test.
> 
> Regards,
> Vladimir
> 
> On 1/3/17 10:03 AM, Doerr, Martin wrote:
> > Hi Vladimir,
> >
> > thanks a lot.
> >
> > There's another s390 change (from Götz) which needs sponsoring because
> it changes a test file.
> > 8172049: [s390] Implement "JEP 270: Reserved Stack Areas for	Critical
> Sections".
> > Webrev is here:
> > http://cr.openjdk.java.net/~goetz/wr16/8172049-
> s390_reservedStack/webrev.02/
> > I'd be great if you could push this one, too. The s390 part is reviewed.
> >
> > Best regards,
> > Martin
> >
> >
> > -----Original Message-----
> > From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> > Sent: Dienstag, 3. Januar 2017 18:58
> > To: Doerr, Martin <martin.doerr at sap.com>; 'hotspot-compiler-
> dev at openjdk.java.net' <hotspot-compiler-dev at openjdk.java.net>
> > Subject: Re: RFR(XS): 8172199: s390: Use same
> get_key_start_from_aescrypt_object implementation as PPC64
> >
> > Looks good. I will sponsor it.
> >
> > Thanks,
> > Vladimir
> >
> > On 1/3/17 8:34 AM, Doerr, Martin wrote:
> >> Hi,
> >>
> >> s390 has the same problem as PPC64 wrt.
> get_key_start_from_aescrypt_object.
> >>
> >> Please review this small webrev:
> >>
> >> http://cr.openjdk.java.net/~mdoerr/8172199_s390_aes_key/webrev.00/
> >>
> >> I will need a sponsor.
> >>
> >> Thanks and best regards,
> >>
> >> Martin
> >>


More information about the hotspot-compiler-dev mailing list