[9] RFR 8173158: [AOT] fix typo in jaotc --help output

Rickard Bäckman rickard.backman at oracle.com
Wed Jan 25 10:16:16 UTC 2017


Good.

On 01/24, Vladimir Kozlov wrote:
> http://cr.openjdk.java.net/~kvn/8173158/webrev.v2/
> 
> Here is updated jaotc --help output I will push.
> Note, I did not change any jaotc functionality.
> 
> The output has more general wording for --search-path and --directory options so we can extend them later.
> And " A : separated list " is mentioned only at the beginning of output:
> 
> % jaotc --help
> Usage: jaotc <options> list
> 
>   list       A : separated list of class names, modules, jar files
>              or directories which contain class files.
> 
> where options include:
>   --output <file>            Output file name
>   --class-name <class names> List of classes to compile
>   --jar <jarfiles>           List of jar files to compile
>   --module <modules>         List of modules to compile
>   --directory <dirs>         List of directories where to search for files to compile
>   --search-path <dirs>       List of directories where to search for specified files
>   --compile-commands <file>  Name of file with compile commands
>   --compile-for-tiered       Generate profiling code for tiered compilation
>   --compile-with-assertions  Compile with java assertions
>   --compile-threads <number> Number of compilation threads to be used
>   --ignore-errors            Ignores all exceptions thrown during class loading
>   --exit-on-error            Exit on compilation errors
>   --info                     Print information during compilation
>   --verbose                  Print verbose information
>   --debug                    Print debug information
>   --help                     Print this usage message
>   --version                  Version information
>   -J<flag>                   Pass <flag> directly to the runtime system
> 
> 
> Thanks,
> Vladimir
> 
> On 1/24/17 10:49 AM, Vladimir Kozlov wrote:
> >Originally I wanted to use --search-path for all types: .class, .jmod, .jar
> >
> >We have --directory option which is only used to load all .class files in this directory. I actually wanted to use it to load all file types in that directory.
> >
> >That is why I am thinking that these 2 options are "the same". We can make --search-path work as --directory if there is no list value specified (load everything from that directory).
> >
> >Hmm, I think we can expand/update functionality of these flags later in jdk 10.
> >
> >Okay, I think I know what to do with these changes. I will keep --directory without renaming. And I will update help output that --search-path is used only for .jar
> >
> >Thanks,
> >Vladimir
> >
> >On 1/24/17 10:30 AM, Rickard Bäckman wrote:
> >>We can use --jar with full path. But the original reason we added it was
> >>because you wanted to the user to type less.
> >>
> >>So instead of jaotc --jar
> >>/some/path/where/jar1.jar:/some/path/where/jar2.jar:/some/path/other/jar3.jar:/some/path/other/jar4.jar
> >>
> >>we can have
> >>jaotc --search-path /some/path/where:/some/path/other
> >>jar1.jar:jar2.jar:jar3.jar:jar4.jar
> >>
> >>Less typing.
> >>
> >>/R
> >>
> >>On 01/24, Vladimir Kozlov wrote:
> >>>Thank you for explaining. I will update help output.
> >>>
> >>>Thanks,
> >>>Vladimir
> >>>
> >>>On 1/24/17 12:53 AM, Rickard Bäckman wrote:
> >>>>On 01/23, Vladimir Kozlov wrote:
> >>>>>Thank you, Rickard
> >>>>>
> >>>>>On 1/23/17 5:42 AM, Rickard Bäckman wrote:
> >>>>>>Good.
> >>>>>>But if you are changing the help. --search-path is only used for jar
> >>>>>>files now.
> >>>>>
> >>>>>Not for modules? What is used for modules then?
> >>>>
> >>>>--module <name> loads from the loaded modules in the jrt:// filesystem.
> >>>>It doesn't search the normal filesystem. --jar works for that.
> >>>>
> >>>>/R
> >>>>
> >>>>>
> >>>>>Thanks,
> >>>>>Vladimir
> >>>>>
> >>>>>>
> >>>>>>/R
> >>>>>>
> >>>>>>On 01/21, Vladimir Kozlov wrote:
> >>>>>>>http://cr.openjdk.java.net/~kvn/8173158/webrev/
> >>>>>>>https://bugs.openjdk.java.net/browse/JDK-8173158
> >>>>>>>
> >>>>>>>Small cleanup of jaotc --help output. Fix typo, reorder printing order.
> >>>>>>>
> >>>>>>>Changed description of list values similar to javac flags. But I am
> >>>>>>>not sure about this - may be is better to have comment following
> >>>>>>>flags that "List values use : as separator". What do you think?
> >>>>>>>
> >>>>>>>Rename following options but keep previous name as alias (both names
> >>>>>>>are accepted):
> >>>>>>>
> >>>>>>>--classname : --class-name
> >>>>>>>--directory : --class-directory
> >>>>>>>--threads   : --compile-threads
> >>>>>>>
> >>>>>>>After changes 'jaotc --help' output:
> >>>>>>>
> >>>>>>>Usage: jaotc <options> | <list...>
> >>>>>>>
> >>>>>>>list    A list of class names, modules, jar files or directories which
> >>>>>>>        contains class files.
> >>>>>>>
> >>>>>>>where options include:
> >>>>>>>--output <file>            Output file name
> >>>>>>>--class-name <class names> A : separated list of classes to compile
> >>>>>>>--class-directory <dirs>   A : separated list of directories where
> >>>>>>>to search for class files to compile
> >>>>>>>--jar <jarfiles>           A : separated list of jar files to compile
> >>>>>>>--module <modules>         A : separated list of modules to compile
> >>>>>>>--search-path <dirs>       A : separated list of directories where
> >>>>>>>to search for jar files and modules
> >>>>>>>--compile-commands <file>  Name of file with compile commands
> >>>>>>>--compile-for-tiered       Generate profiling code for tiered compilation
> >>>>>>>--compile-with-assertions  Compile with java assertions
> >>>>>>>--compile-threads <number> Number of compilation threads to be used
> >>>>>>>--ignore-errors            Ignores all exceptions thrown during
> >>>>>>>class loading
> >>>>>>>--exit-on-error            Exit on compilation errors
> >>>>>>>--info                     Print information during compilation
> >>>>>>>--verbose                  Print verbose information
> >>>>>>>--debug                    Print debug information
> >>>>>>>--help                     Print this usage message
> >>>>>>>--version                  Version information
> >>>>>>>-J<flag>                   Pass <flag> directly to the runtime system
> >>>>>>>
> >>>>>>>Thanks,
> >>>>>>>Vladimir
/R


More information about the hotspot-compiler-dev mailing list