RFR: 8167519: [AOT] Failed compilation: java.math.MutableBigInteger.divide3n2n

[Gilles Duboscq]

Hi,

The version pushed in graal-core has been reviewed internally by Tom Rodriguez and David Leopoldseder.
Tom is Reviewer for jdk9.

  Gilles

On 01/24/2017 07:34 PM, Vladimir Kozlov wrote:
> Yes, we need at least one official reviewer. Tom is Reviewer - we can use him for all Graal changes ;)
>
> It is more dubious to list one from our group as Reviewer since we know about Graal much less (for now).
>
> Thanks,
> Vladimir
>
> On 1/24/17 10:25 AM, Rickard Bäckman wrote:
>> But we also need to make sure they are actually reviewers for the jdk9
>> project?
>>
>> On 01/24, Vladimir Kozlov wrote:
>>> It was pushed into GRaal-core already and it was reviewed. We need
>>> to setup workflow for such cases. Specifically for Graal changes
>>> like this when we don't have experts in our group to do review ;)
>>>
>>> Sending formal RFR to this compiler mailing list is good but we can
>>> used Graal reviewers for changeset. May be use it as notification
>>> for this mailing list.
>>>
>>> Anyway, consider it is reviewed. Please, find who reviewed it in Labs and add them as reviewers.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 1/24/17 5:05 AM, Rickard Bäckman wrote:
>>>> Hi,
>>>>
>>>> here is a bug fix for 8167519. Code is contributed by Gilles Duboscq.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8167519
>>>> Webrev: http://cr.openjdk.java.net/~rbackman/8167519/
>>>>
>>>> Gilles is an author in the jdk9 project. I'll sponsor the change.
>>>>
>>>> Thanks
>>>> /R
>>>>
>> /R
>>