[9] RFR(S): 8173373: C1: NPE is thrown instead of LinkageError when accessing inaccessible field on NULL receiver

Tobias Hartmann tobias.hartmann at oracle.com
Tue Jan 31 13:33:13 UTC 2017


Hi Vladimir,

On 31.01.2017 13:25, Vladimir Ivanov wrote:
> Good catch!
> 
>> I missed that the problem also affects putfield (of course). I extended the test accordingly and added the same fix to LIRGenerator::do_StoreField():
>> http://cr.openjdk.java.net/~thartmann/8173373/webrev.03/
> 
> Can you try to factor new code into a helper method?

Sure, what about adding a parameter to __ null_check() to force deoptimization?
http://cr.openjdk.java.net/~thartmann/8173373/webrev.04/

Thanks,
Tobias

> Otherwise, looks good.
> 
> Best regards,
> Vladimir Ivanov
> 
>> On 30.01.2017 13:51, Tobias Hartmann wrote:
>>> Thanks, Vladimir!
>>>
>>> Best regards,
>>> Tobias
>>>
>>> On 30.01.2017 13:48, Vladimir Ivanov wrote:
>>>>> http://cr.openjdk.java.net/~thartmann/8173373/webrev.02/
>>>>
>>>> Looks good.
>>>>
>>>> Best regards,
>>>> Vladimir Ivanov


More information about the hotspot-compiler-dev mailing list