RFR: 8183151: DCmd Compiler.codelist should print all compiled methods

[Nils Eliasson]

Fixed it.

Thanks Vladimir!

Regards,

Nils


On 2017-07-03 20:40, Vladimir Kozlov wrote:
> Looks good but indent in test is wrong in one line:
>
> 115 String line = lines.next();
>
> Thanks,
> Vladimir
>
> On 7/3/17 3:20 AM, Nils Eliasson wrote:
>> Hi,
>>
>> I had to adapt the test for this dcmd for the new printout format 
>> with an extra column.
>>
>> http://cr.openjdk.java.net/~neliasso/8183151/webrev.01/
>>
>> Regards,
>> Nils
>>
>> On 2017-06-30 19:52, Christian Thalinger wrote:
>>>> On Jun 30, 2017, at 3:46 AM, Nils Eliasson 
>>>> <nils.eliasson at oracle.com> wrote:
>>>>
>>>> Hi Chris,
>>>>
>>>> I considered asking you to change the comp_level output to 
>>>> something more descriptive like A for AOT. But such a changed 
>>>> should be done in a consistent manner in a number of places, so 
>>>> I'll leave that for later.
>>> I was thinking about that too but then left it.
>>>
>>>> Looks good, thanks for fixing!
>>>>
>>>> Do you want me to push it?
>>> Yes, please.
>>>
>>>> Best regards,
>>>>
>>>> Nils
>>>>
>>>> On 2017-06-28 21:38, Christian Thalinger wrote:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8183151
>>>>>
>>>>> Right now Compiler.codelist only prints JIT compiled methods 
>>>>> (nmethods) but it should print AOT compiled methods as well.
>>>>>
>>>>> The patch also adds an additional column to show the "state" of 
>>>>> the method. It can be important to know if the method is active or 
>>>>> not.
>>>>>
>>>>> 473 4 0 java.util.zip.ZipFile$Source.initCEN(I)V 
>>>>> [0x0000000109fe0190, 0x0000000109fe0440 - 0x0000000109fe27f8]
>>>>> 499 4 2 
>>>>> java.util.Collections$UnmodifiableCollection$1.next()Ljava/lang/Object; 
>>>>> [0x0000000109fe3790, 0x0000000109fe3960 - 0x0000000109fe3b00]
>>>>>
>>>>> AOT compiled code shows up with a compile level of -1:
>>>>>
>>>>> 819 -1 0 
>>>>> jdk.vm.ci.code.RegisterValue.<init>(Ljdk/vm/ci/meta/ValueKind;Ljdk/vm/ci/code/Register;)V 
>>>>> [0x00007fe3e2623af0, 0x000000010df35468 - 0x000000010df35760]
>>>>> 820 -1 0 
>>>>> jdk.vm.ci.code.RegisterValue.getRegister()Ljdk/vm/ci/code/Register; 
>>>>> [0x00007fe3e2623c00, 0x000000010df357e8 - 0x000000010df35868]
>>>>> 821 -1 0 jdk.vm.ci.code.RegisterValue.equals(Ljava/lang/Object;)Z 
>>>>> [0x00007fe3e2623d10, 0x000000010df358e8 - 0x000000010df35b08]
>>>>>
>>>>> Patch is attached to the ticket.
>>