RFR (S): 8183575: Runtime1::oop_arraycopy is unused and should be removed

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Jul 6 15:22:53 UTC 2017


Good.

Thanks,
Vladimir

On 7/6/17 2:38 AM, Erik Österlund wrote:
> Hi Vladimir,
> 
> Thank you for the review.
> 
> Nice find that primitive_arraycopy() could also be removed. Removed code 
> is the best kind of code. So let's remove that one too (and its counter) 
> while we are at it.
> 
> New full webrev:
> http://cr.openjdk.java.net/~eosterlund/8183575/webrev.01/
> 
> Incremental:
> http://cr.openjdk.java.net/~eosterlund/8183575/webrev.00_01/
> 
> Testing: JPRT
> 
> Thanks,
> /Erik
> 
> On 2017-07-05 19:35, Vladimir Kozlov wrote:
>> Thank you, Erik
>>
>> primitive_arraycopy() could be also removed. Both methods were 
>> replaced with arraycopy stub methods long ago:
>>
>> https://bugs.openjdk.java.net/browse/JDK-7033154
>> http://hg.openjdk.java.net/jdk9/dev/hotspot/rev/13bc79b5c9c8
>>
>> Thanks,
>> Vladimir
>>
>> On 7/5/17 8:36 AM, Erik Österlund wrote:
>>> Hi,
>>>
>>> I noticed that Runtime1::oop_arraycopy is not referenced from 
>>> anywhere in the code. So therefore I would like to remove it and its 
>>> corresponding Runtime1::_oop_arraycopy_cnt counter.
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8183575
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~eosterlund/8183575/webrev.00/
>>>
>>> Testing: JPRT with hotspot tests.
>>>
>>> Thanks,
>>> /Erik
> 


More information about the hotspot-compiler-dev mailing list