skip jcstress tests when running jtreg
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Wed Jul 19 14:53:47 UTC 2017
Hi Igor,
thanks for the advice! A group as 8179603 proposes is just fine for our
purposes.
Also, we appreciate the jcstress tests are integrated in jtreg. Currently
we have a custom wrapper around them to run them in our nightly
tests we happily will dispose of ... but we need to run them separately
for the obvious reasons.
Best regards,
Goetz.
> -----Original Message-----
> From: Igor Ignatyev [mailto:igor.ignatyev at oracle.com]
> Sent: Dienstag, 18. Juli 2017 21:51
> To: Roman Kennke <rkennke at redhat.com>; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>
> Cc: hotspot-compiler-dev at openjdk.java.net; Zeller, Arno
> <arno.zeller at sap.com>
> Subject: Re: skip jcstress tests when running jtreg
>
> Hi Roman, Goetz,
>
>
> Although I do understand and share your pain associated w/ running jsctress
> thru jtreg, I still think that we took the right way of integration, since it is
> intended to unify tests, simply the rest of infrastructure and it consists w/
> our vision that all tests for jdk should be runnable by one target in make.
> unfortunately, in some cases it doesn't work that well for Open JDK
> community and I'd like to assure you that build team is aware of that and
> working towards to make it as transparent as possible for anyone.
>
>
> regarding your question, currently there is no good way to filter out jsctress
> or other "application" tests from :hotspot_all group. I'd prefer us not to use
> keywords for test selection, since it might further complicate our lives,
> instead I think we should create dedicated test groups based on various test
> properties (such as execution time, external dependencies, etc), this will be
> addressed JDK-8179603[1]. until it's done, you can use the same (a bit ugly)
> workaround as we do -- run :hotspot_gc, :hotspot_runtime,
> :hotspot_serviceability and :hotspot_misc groups when you want to run
> :hotspot_all minus application tests, and run jtreg for test/applications
> directory to run all application tests.
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8179603
>
>
> Thanks,
> -- Igor
>
>
>
> On Jul 18, 2017, at 8:24 AM, Roman Kennke <rkennke at redhat.com
> <mailto:rkennke at redhat.com> > wrote:
>
> +1!
>
> I'd just run upstream jcstress instead and avoid the problematic
> jcstress stuff in jtreg.
>
> Roman
>
> Am 18.07.2017 um 17:21 schrieb Lindenmaier, Goetz:
>
>
> Hi Igor,
>
> We used to execute all jtreg tests via group hotspot_all.
> Since the jcstress tests were submitted we run into timeouts
> and other problems.
>
> We would like to run all tests but the jcstress tests, and
> then run the jcstress tests in a run of its own.
> Unfortunately, we didn’t find a good way to exclude them.
>
> It seems not to work to add
> applications/jcstress/acqrel/Test.java generic-all
> to the ProblemList.txt.
> There is no specific group in TEST.groups.
> Also, there is no keyword associated with the tests.
>
> Is there a way to exclude these but run all others I oversaw?
> Would it make sense to add @key stress to all the jcstress
> tests?
> Should we add a group hotspot_all_no_jcstress or the like to
> TEST.groups?
>
> Best regards,
> Goetz.
>
>
>
>
>
>
>
>
>
More information about the hotspot-compiler-dev
mailing list