8184800: Streamline RTM flag validity testing with generic flag testing support.

[Vladimir Kozlov]

Thank you, Goetz

Looks good to me.

Thanks,
Vladimir

On 7/19/17 3:37 AM, Lindenmaier, Goetz wrote:
> Hi,
> 
> please review this change. I please need a sponsor.
> 
> http://cr.openjdk.java.net/~goetz/wr17/8184800-rtmFlags/webrev.01/
> 
> RTM was implemented before specifying ranges for flags was established
> 
> in openJdk. It has custom checks implemented per platform in
> 
> vm_version_<cpu>.cpp as well as tests for these checks in compiler/rtm/cli.
> 
> 8180612 added ranges for a row of RTM flags. Tests for RTMAbortRatio
> 
> and RTMTotalCountIncrRate now fail, because the range check failure
> 
> message is different.
> 
> This change removes the custom checks, implements a generic method
> 
> RTMTotalCountIncrRateConstraintFunc() and updates the tests. Some
> 
> tests are now superfluous as the ranges will be tested by
> 
> TestOptionsWithRanges.
> 
> I tested on x86/ppc machines with and without RTM support, as well
> 
> as on the other platforms we test automated.
> 
> Best regards,
> 
>    Goetz.
>