RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Tue Jul 25 07:37:41 UTC 2017


Hi Vladimir, 

I added all of them.  And I think I got the copyrights right, now.
http://cr.openjdk.java.net/~goetz/wr17/8185046-aotKey/webrev.02/index.html

Best regards,
  Goetz.

> -----Original Message-----
> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> Sent: Montag, 24. Juli 2017 18:19
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-compiler-
> dev at openjdk.java.net
> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
> 
> On 7/23/17 11:31 PM, Lindenmaier, Goetz wrote:
> > Hi Vladimir,
> >
> > I left them out because they didn't cause errors even without
> INCLUDE_AOT.
> > I must add the AotInvokeDynamic ones, as they will fail once the @ignore is
> > removed.
> > But as I understand the
> >> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
> > don't depend on aot. Should I tag them anyways?
> 
> Yes, please.
> 
> Vladimir
> 
> >
> > Best regards,
> >    Goetz.
> >
> >> -----Original Message-----
> >> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> >> Sent: Freitag, 21. Juli 2017 18:49
> >> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-
> compiler-
> >> dev at openjdk.java.net
> >> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
> >>
> >> Thank you, Goetz
> >>
> >> I think you missed few tests.
> >>
> >> There are 7 junit tests:
> >>
> >> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
> >>
> >> And 4 calls tests:
> >>
> >> compiler/aot/calls/fromAot/AotInvokeDynamic*
> >>
> >> Thanks,
> >> Vladimir
> >>
> >> On 7/21/17 3:57 AM, Lindenmaier, Goetz wrote:
> >>> Hi,
> >>>
> >>> if we build without INCLUDE_AOT, we need to exclude the aot tests.
> >>>
> >>> I added keyword 'aot' to all those that fail if AOT is missing.
> >>>
> >>> Please review this change. I please need a sponsor.
> >>>
> >>> http://cr.openjdk.java.net/~goetz/wr17/8185046-
> >> aotKey/webrev.01/index.html
> >>>
> >>> Best regards,
> >>>
> >>>     Goetz.
> >>>


More information about the hotspot-compiler-dev mailing list