[10] RFR(S) 8180785: [AOT][GRAAL] java.lang.AssertionError: Method not found: jdk.internal.misc.Unsafe.compareAndSwapInt

[Vladimir Kozlov]

Thank you, Doug

On 6/6/17 2:26 PM, Doug Simon wrote:
>
>> On 6 Jun 2017, at 22:45, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>
>> webrev: http://cr.openjdk.java.net/~kvn/8180785/webrev/
>
> The entries in the intrinsics lists need to be ordered (running `mx unittest CheckGraalIntrinsics` will show the issue).

I updated webrev with ordered intrinsics names. And I found that I forgot to rename weakCompareAndSwap*() to weakCompareAndSet*Plain() according to JDK changes:

http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/c9299e0bb7b9#l12.125

`mx unittest CheckGraalIntrinsics` passed:

OK (1 test)

Thanks,
Vladimir

>
>>
>> https://bugs.openjdk.java.net/browse/JDK-8180785
>>
>> AOT jtreg tests fail due to 8159995 [1] changes which renamed some methods in jdk.internal.misc.Unsafe
>> The fix does renaming in Graal code which use jdk.internal.misc.Unsafe. It should go through Graal-core review process and pushed there (Oracle Labs repository) first. Doug, please, help with it.
>
> Internal changes have been prepared.
>
>> Note, JDK 9 will be updated soon [2] to get the same renaming so Graal-core does not need to check for JDK 10 specifically. But changes should be pushed only after [2] is pushed into jdk9/dev and get into promoted build which people use with Graal.
>>
>> Second note. The copy of Graal-core in jdk9 (jdk.internal.vm.compiler) will be fixed by [2] changes.
>>
>> I looked on other places in Graal where such methods are used and they are from sun.misc.Unsafe class. Those places have to be fixed too when sun.misc.Unsafe become obsolete.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8159995
>> [2] https://bugs.openjdk.java.net/browse/JDK-8181292
>
> -Doug
>