[10] RFR(S): 8181781: Replay compilation should ignore unresolved Klass with -XX:+ReplayIgnoreInitErrors

Tobias Hartmann tobias.hartmann at oracle.com
Fri Jun 9 06:47:25 UTC 2017


Hi Vladimir,

thanks for the review!

Best regards,
Tobias

On 08.06.2017 20:42, Vladimir Kozlov wrote:
> Good. Thank you, Tobias, for fixing this.
> 
> Vladimir
> 
> On 6/8/17 4:21 AM, Tobias Hartmann wrote:
>> Hi,
>>
>> please review the following patch:
>> https://bugs.openjdk.java.net/browse/JDK-8181781
>> http://cr.openjdk.java.net/~thartmann/8181781/webrev.00/
>>
>> Replay compilation currently crashes if a Klass referenced in ciMethodData cannot be resolved. However, in many cases it's not necessary to resolve the class for replay compilation to succeed. We should be more conservative if -XX:+ReplayIgnoreInitErrors is set. I noticed this while debugging JDK-8181741. The generated replay compilation files fail because ciMethodData for AnnotationParser::parseAnnotations2 contains a reference to com/sun/proxy/jdk/proxy2/$Proxy4 which cannot be resolved. However, if we ignore those resolution failures compilation succeeds and the bug easily reproduces.
>>
>> Thanks,
>> Tobias
>>


More information about the hotspot-compiler-dev mailing list