[10] RFR: 8044829: UseAES warning message generation differs on CPU architecture
Rahul Raghavan
rahul.v.raghavan at oracle.com
Fri Jun 16 20:24:07 UTC 2017
Hi,
Please review the following fix proposal.
<webrev.00> - http://cr.openjdk.java.net/~rraghavan/8044829/webrev.00/
src/cpu/x86/vm/vm_version_x86.cpp - 3 lines changed: 0 ins; 3 del; 0 mod; 1436 unchg
src/cpu/x86/vm/assembler_x86.cpp - 8 lines changed: 0 ins; 0 del; 8 mod; 8843 unchg
No issues with jprt (-testset hotspot) testing.
Please refer <jbs> comments - https://bugs.openjdk.java.net/browse/JDK-8044829
1. Proposed fix changes in 'vm_version_x86.cpp' fixes the wrong warning generated for options -XX:-UseAES -XX:+UseAESIntrinsics.
void VM_Version::get_processor_features() {
.........
- if (!UseAES && !FLAG_IS_DEFAULT(UseAES))
- _features &= ~CPU_AES;
-
.e.g.: wrong warning without fix for x64, WITH AES support -
Java HotSpot(TM) 64-Bit Server VM warning: AES intrinsics are not available on this CPU
.e.g.: correct warning with fix - (same as already fixed for sparc)
Java HotSpot(TM) 64-Bit Server VM warning: AES intrinsics require UseAES flag to be enabled. Intrinsics will be disabled.
2. Seems additional changes as proposed maybe required in 'assembler_x86.cpp' after changes in 'vm_version_x86.cpp'.
3. Found issues reported earlier for sparc was solved with 8131778 fix in 9-b96.
Found no similar issues with other targets.
Thanks,
Rahul
More information about the hotspot-compiler-dev
mailing list