RFR: 8182727: [Graal] all compiler/intrinsics/mathexact/sanity/ tests fail
Christian Thalinger
cthalinger at twitter.com
Tue Jun 27 20:55:27 UTC 2017
Sorry. This is fixed in 9 by JDK-8130832. Somehow I got confused with JDK versions.
> On Jun 22, 2017, at 10:34 AM, Christian Thalinger <cthalinger at twitter.com> wrote:
>
> https://bugs.openjdk.java.net/browse/JDK-8182727 <https://bugs.openjdk.java.net/browse/JDK-8182727>
>
> The issue is that these tests are expecting an intrinsic to show up in LogCompilation output. Graal doesn't use LogCompilation. There are many ways to fix this but the right fix is in WB_IsIntrinsicAvailable:
>
> diff --git a/src/share/vm/prims/whitebox.cpp b/src/share/vm/prims/whitebox.cpp
> --- a/src/share/vm/prims/whitebox.cpp
> +++ b/src/share/vm/prims/whitebox.cpp
> @@ -751,6 +751,11 @@
> if (compLevel < CompLevel_none || compLevel > MIN2((CompLevel) TieredStopAtLevel, CompLevel_highest_tier)) {
> return false; // Intrinsic is not available on a non-existent compilation level.
> }
> +#if INCLUDE_JVMCI
> + if (UseJVMCICompiler && compLevel == CompLevel_highest_tier) {
> + return false; // Intrinsic does not exist in JVMCI compiler.
> + }
> +#endif
> jmethodID method_id, compilation_context_id;
> method_id = reflected_method_to_jmid(thread, env, method);
> CHECK_JNI_EXCEPTION_(env, JNI_FALSE);
>
> Since this method is making its decision solely based on the compilation level this is just doomed to fail. We need to return false in the case of tier 4 and a JVMCI compiler being used.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20170627/a2fdd74e/attachment-0001.html>
More information about the hotspot-compiler-dev
mailing list