[9] RFR: 8175345: possible null pointer dereference defects

[Vladimir Kozlov]

Good.

Thanks,
Vladimir

On 3/8/17 10:58 PM, Rahul Raghavan wrote:
> Hi,
>
> Thank you Vladimir for review comments.
> Yes agree with the proposed change in callnode.cpp.
>
> Please find the revised <webrev.02> -
>   http://cr.openjdk.java.net/~rraghavan/8175345/webrev.02/
>
> Thanks,
> Rahul
>
>> -----Original Message-----
>> From: Vladimir Kozlov
>> Sent: Thursday, March 09, 2017 6:54 AM
>> To: Rahul Raghavan; hotspot-compiler-dev at openjdk.java.net
>> Subject: Re: [9] RFR: 8175345: possible null pointer dereference defects
>>
>> callnode.cpp  - proj_out() is expensive. I would suggest to check returns_pointer() first:
>>
>>         Node* proj = returns_pointer() ? proj_out(TypeFunc::Parms) : NULL;
>>         if (proj != NULL) {
>>           const TypeInstPtr* inst_t = phase->type(proj)->isa_instptr();
>>
>> Other files changes are fine.
>>
>> thanks,
>> Vladimir
>>