RFR (S) 8176580: [ppc, s390] CRC32C: wrong checksum result in some cases

[Schmidt, Lutz]

Hi Andrew, 

this is a very good question indeed. My answer is two-fold:

No, for this particular bug it’s not worth to create a separate test. There already exists at least one in the Java9 JCK suite:
  api/java_util/zip/CRC32C/td.html#TestAsChecksum

Yes, one might think of running a test suite subset multiple times with different parameters. In this case, -Xint and/or –Xcomp were helpful. Forcing tests to run fully interpreted or fully compiled helps in cases where a certain function, e.g. an intrinsic, is invoked via distinct code paths. 

Regards, 
Lutz



On 14.03.17, 11:16, "Andrew Haley" <aph at redhat.com> wrote:

    On 14/03/17 08:16, Schmidt, Lutz wrote:
    > may I kindly request reviews for my small bugfix? And somebody volunteering as a sponsor would be welcome as well.
    > 
    > Bug: https://bugs.openjdk.java.net/browse/JDK-8176580
    > Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8176580/
    
    Is there any addition to the test suite needed for this?
    
    Andrew.