[9] RFR(XS): 8176513 Poor code quality for ByteBuffers

[Vladimir Kozlov]

So what is final fix looks like?

Vladimir K


Sent from my iPhone
> On Mar 15, 2017, at 8:50 AM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
> 
> Good point, Roland. Missed those checks.
> 
> What is missing is TypeInstPtr::MARK, but I'm fine with fixing that later.
> 
> Best regards,
> Vladimir Ivanov
> 
>> On 3/15/17 6:34 PM, Roland Westrelin wrote:
>> 
>>> I think alias_type->adr_type() should be used instead, because
>>> adr_type->isa_aryptr() is true for pointers into array header as well,
>>> but we care about array body here. Alias analysis should flatten them to
>>> InstPtr.
>> 
>> Aren't those forbidden anyway?
>> 
>>  if (alias_type->adr_type() == TypeInstPtr::KLASS ||
>>      alias_type->adr_type() == TypeAryPtr::RANGE) {
>>    return false; // not supported
>>  }
>> 
>> Roland.
>>