RFR: 8177069: File separator mismatch on Win-64

Rickard Bäckman rickard.backman at oracle.com
Tue Mar 28 11:06:16 UTC 2017


Removed the comment, changed to getAbsolutePath. Thanks I didn't know
that method would do the job.

Thanks for the review.

On 03/24, dean.long at oracle.com wrote:
> And how about using File.getAbsoluteFile() here:
> 
> 51 public static Path getpath(String path) {
> 52 if (path.startsWith("/") &&
> System.getProperty("os.name").startsWith("Windows")) {
> 53 path = "C:\\" + path.substring(1);
> 54 }
> 55 return Paths.get(path);
>   56     }
> 
> 
> dl
> 
> On 3/24/17 12:55 PM, dean.long at oracle.com wrote:
> >
> >Did you forget to remove this println?
> >
> >
> >   61     public void itShouldUsePathIfPathIsAbsoluteAndExisting() {
> >62 System.out.println(System.getProperty("os.name"));
> >
> >dl
> >
> >On 3/24/17 6:17 AM, Rickard Bäckman wrote:
> >>Hi, can I please have this patch reviewed?
> >>
> >>With AOT being ported to Windows some of the file path stuff had to be
> >>updated.
> >>
> >>Webrev:http://cr.openjdk.java.net/~rbackman/8177069.2/
> >>Bugs:https://bugs.openjdk.java.net/browse/JDK-8177069
> >>
> >>Thanks
> >>/R
> >
> 
/R


More information about the hotspot-compiler-dev mailing list