HotSpotResolvedJavaMethod#setNotInlineable() in JVMCI

[Christian Thalinger]

> On May 15, 2017, at 8:27 PM, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
> 
> Hi all,
> 
> I've tried to use JVMCI implementation.
> 
> HotSpotResolvedJavaMethod#setNotInlineable() is explained that "Manually adds a DontInline annotation to this method" in the comment, however this method seems to disable C1/C2 compile in CompilerToVM [1][2].
> 
> Is this behavior correct?
> Should we fix the comment or method name (and / or function name) or behavior in jvmciCompilerToVM.cpp ?

Yes, that’s a bit confusing.  I think HotSpotResolvedJavaMethodImpl.setNotInlineable should be renamed and the documentation updated.

> 
> 
> I will file it to JBS if it is a bug.
> 
> 
> Thanks,
> 
> Yasumasa (ysuenaga)
> 
> 
> [1] http://hg.openjdk.java.net/jdk9/dev/hotspot/file/d6d7e5caf497/src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java#l320 <http://hg.openjdk.java.net/jdk9/dev/hotspot/file/d6d7e5caf497/src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java#l320>
> [2] http://hg.openjdk.java.net/jdk9/dev/hotspot/file/d6d7e5caf497/src/share/vm/jvmci/jvmciCompilerToVM.cpp#l1004 <http://hg.openjdk.java.net/jdk9/dev/hotspot/file/d6d7e5caf497/src/share/vm/jvmci/jvmciCompilerToVM.cpp#l1004>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20170516/cf28572b/attachment-0001.html>