[10] RFR(XS): 8180473: Use proper deallocation for FileBuff::_bigbuf

Zoltán Majó zoltan.majo at oracle.com
Wed May 17 10:52:10 UTC 2017


Hi,


please review the following fix for 8180473.
https://bugs.openjdk.java.net/browse/JDK-8180473
http://cr.openjdk.java.net/~zmajo/8180473/webrev.00/

It is a good coding practice to properly deallocate dynamically 
allocated resources. In particular, dynamically allocated memory for 
arrays using the array-specific new[] operator is supposed to be 
deallocated using the array-specific delete[] operator. The deallocation 
of FileBuff::_bigbuf does not follow this recommendation and should 
therefore be changed. Tested with JPRT.

Thank you!

Best regards,


Zoltan



More information about the hotspot-compiler-dev mailing list