RFR: JDK-8180487: HotSpotResolvedJavaMethod#setNotInlineable() should be renamed to represent actual behavior
Doug Simon
doug.simon at oracle.com
Thu May 18 12:41:13 UTC 2017
> On 18 May 2017, at 14:28, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
>
> Thanks Doug!
>
> BTW, could you be a sponsor?
I'd prefer it if one of the compiler devs could do it. Vladimir, can you take care of this?
-Doug
> On 2017/05/18 21:27, Doug Simon wrote:
>> Thanks for the update - the changes look good to me.
>>
>> -Doug
>>
>>> On 18 May 2017, at 14:12, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
>>>
>>> Hi Doug,
>>>
>>> Thank you for your comment.
>>>
>>> I uploaded new webrev.
>>> Could you check again?
>>>
>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8180487/webrev.01/
>>>
>>>
>>> Yasumasa
>>>
>>>
>>> On 2017/05/18 18:11, Doug Simon wrote:
>>>> The code changes look good. However, the javadoc still describes the functionality as a query:
>>>>
>>>> /**
>>>> * Determines if {@code method} should not be inlined or compiled.
>>>> */
>>>>
>>>> where as it's really a setter. That is, the comment should be:
>>>>
>>>> /**
>>>> * Sets flags on {@code method} indicating that it should never be inlined or compiled by the VM.
>>>> */
>>>>
>>>> -Doug
>>>>
>>>>> On 18 May 2017, at 05:18, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
>>>>>
>>>>> Hi all,
>>>>>
>>>>> This review request is related to [1].
>>>>>
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8180487
>>>>> Patch: http://cr.openjdk.java.net/~ysuenaga/JDK-8180487/webrev.00/
>>>>>
>>>>> Could you review it?
>>>>>
>>>>> I cannot access JPRT.
>>>>> So I need a sponsor.
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Yasumasa
>>>>>
>>>>>
>>>>> [1] http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2017-May/026218.html
>>>>
>>
More information about the hotspot-compiler-dev
mailing list